logging: Switch from lumberjack to timberjack, add time-rolling options
#7244
Conversation
|
|
|
Oh, fantastic! I didn't get the memo that a fork was worked on, we were waiting for someone to pick up the mantle. Will review soon. |
francislavoie
changed the title
lumberjack to timberjack add time-rolling options
francislavoie
changed the title
lumberjack to timberjack add time-rolling optionslumberjack to timberjack, add time-rolling options
|
This is looking great. I am happy to merge this, I just need to give it one closer look first. |
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
Ok yeah this looks great. Thank you!
I second Francis' comments -- if we can clarify some docs and address the things he brought up, I'd say let's merge it. 👍
|
👍 I try to fix docs & cie this week-end ! |
|
Thanks! FYI timberjack had a new release just now to add support for zstd compression (we should expose that option too) & adding a reason to manual rotation (so we could add support for rotating the files on config reload). Another requested nice-to-have, we could also add support for opt-in reopening of the log file on config reload, useful for when users use their own external log rolling instead of what we provide them, we should reopen the log file so it correctly points to the new file instead of the moved file. |
aeris
force-pushed
the
timberjack-rotate-at
branch
from
310f7df to
6ff7126
Compare
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
This is looking good to me now. @francislavoie What do you think? (Maybe we can add the zstd and reopening in a later PR if not this one.)
|
I can try another PR for the zstd support |
aeris
force-pushed
the
timberjack-rotate-at
branch
2 times, most recently
from
0999b6d to
1a41234
Compare
|
Huh, we got a data race, that's not good. @DeRuina maybe you have an idea what the problem is? |
|
@francislavoie I'm fixing the issues |
DeRuina
left a comment
DeRuina
left a comment
There was a problem hiding this comment.
timberjack has a new version v1.3.8 which was just published. All of the data races issues are solved.
You can proceed and merge the PR
|
Upgraded and pushed 😊 |
|
I think you also need to run |
|
I went ahead and ran |
francislavoie
force-pushed
the
timberjack-rotate-at
branch
from
ee36534 to
49d2aaf
Compare
|
Thanks everyone! |
|
\o/ |
|
Happy this was merged. If you guys need any other features in the future like adding more compression options or anything else that will serve caddy let me know and I will work on it :) |
|
Awesome, thank you @DeRuina ! We'd be happy to collaborate with you on more contributions. (Plenty of open issues -- and PRs that could use reviews. We're looking to grow the team.) |
|
@mholt I would be interested and would like to hear more! |
|
@DeRuina Matt is saying, if you'd like to go look through open Caddy issues for something that looks interesting for you to help with, that would be a good way to start if you'd like to help out with something 😅 |
|
Yep. Just get involved with fixing bugs and addressing issues, reviewing existing PRs to help us know whether to merge them, etc, and it may not be long before we add you as a collaborator :) |
5 participants
Lumberjack is unmaintained since 2 years.
A fork exists, Timberjack to replace it with more features.
This PR migrate to Timberjack and add support newest features, specially
RotateAtoptions to allow to rotate log file base on date.Assistance Disclosure
No AI was used.